search

killbill / killbill-analytics-plugin

Kill Bill plugin for financial reporting
https://killbill.io
Apache License 2.0
11 stars 32 forks source link

Oss 552 update parent and testing db server #147

Closed xsalefter closed 1 year ago

xsalefter commented 2 years ago

Some important notes: add "slow" group to @BeforeMethod.

needed because even by default the test is not pass and have a lot of NullPointerException. This is because AnalyticsTestSuiteWithEmbeddedDB extends AnalyticsTestSuiteNoDB, but the @BeforeMethod(groups='slow') is not available for AnalyticsTestSuiteWithEmbeddedDB.

If we need to take another way, let me know.

xsalefter commented 1 year ago

sometimes ago I got problem like this:

Your RubyGems version (2.7.3) has a bug that prevents `required_ruby_version` from working for Bundler. Any scripts that use `gem install bundler` will break as soon as Bundler drops support for your Ruby version. Please upgrade RubyGems to avoid future breakage and silence this warning by running `gem update --system 3.2.3`

but forgot the solution. @pierre any idea?

pierre commented 1 year ago

@pierre any idea?

Nope :/ Maybe it's just a matter of running the Rubygems update command here: https://github.com/killbill/gh-actions-shared/blob/54f69a887f75e7c1e9768eba5f304c6f28ace45e/.github/workflows/integration_test.yml#L112 ?

xsalefter commented 1 year ago

Maybe something like this ?

pierre commented 1 year ago

I've commented on the other PR, feel free to merge so you can re-test once it's addressed.

xsalefter commented 1 year ago

@pierre It is now:

undle complete! 12 Gemfile dependencies, 34 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.
rake aborted!
Don't know how to build task 'ci:analytics' (See the list of available tasks with `rake --tasks`)

I don't know what ci:analytics task is. And fast search in github repositories not showing anything. Perhaps it is mean https://github.com/killbill/killbill-integration-tests/tree/work-for-release-0.23.x/killbill-integration-tests/plugins/analytics test_analytics.rb ?

pierre commented 1 year ago

It looks like the CI configuration needs to be updated following https://github.com/killbill/killbill-integration-tests/commit/b55119b26dbf7ebebfb47547328e93a69d7cbac3.

I had fixed Stripe (https://github.com/killbill/killbill-stripe-plugin/commit/8bb37e9145dd27fe0263c91b88f0709acf691a2a) but not here. Can you do a similar fix (goal is test:plugins:analytics)?