search

killbill / killbill-api

Kill Bill APIs
https://killbill.io
Apache License 2.0
18 stars 34 forks source link

1375 - Renamed method to changePlanWithDateTime #95

Closed reshmabidikar closed 2 years ago

reshmabidikar commented 2 years ago

Renamed changePlanWithDate to changePlanWithDateTime. This is because changePlanWithDate results in some ambiguous method calls in killbill tests (For example hereand in a few other places where a null value is passed.

pierre commented 2 years ago

If this is just for tests, could you just cast the null?

entitlement.changePlanWithDate(new DefaultEntitlementSpecifier(spec2), (LocalDate) null, ImmutableList.<PluginProperty>of(), callContext);

Outside of tests, if the use-case is change plan now, developers can instead use the changePlanOverrideBillingPolicy method.

reshmabidikar commented 2 years ago

Adding a cast works, so closing this PR.