killbill / killbill-cloud

Kill Bill deployment utilities
https://killbill.io
Apache License 2.0
64 stars 85 forks source link

Remove unused options in the kpm diagnostic help command and from the code #270

Closed reshmabidikar closed 6 months ago

reshmabidikar commented 6 months ago

The kpm help diagnostic command currently displays the following options:

  [--account-export=ACCOUNT_EXPORT]           # export account for a provided id.
  [--log-dir=LOG_DIR]                         # (Optional) Log directory if the default tomcat location has changed
  [--config-file=CONFIG_FILE]                 # Yml that contains killbill api connection and DB connection
  [--killbill-api-credentials=one two three]  # Killbill api credentials <api_key> <api_secrets>
  [--killbill-credentials=one two three]      # Killbill credentials <user> <password>
  [--killbill-url=KILLBILL_URL]               # Killbill URL ex. http://127.0.0.1:8080
  [--database-name=DATABASE_NAME]             # DB name to connect
  [--database-credentials=one two three]      # DB credentials <user> <password>
  [--database-host=DATABASE_HOST]             # Database Host name
  [--database-port=DATABASE_PORT]             # Database port
  [--kaui-web-path=KAUI_WEB_PATH]             # Path for the KAUI web app
  [--killbill-web-path=KILLBILL_WEB_PATH]     # Path for the killbill web app
  [--bundles-dir=BUNDLES_DIR]                 # A different folder other than the default bundles directory.
  [--overrides=key:value]                     # A hashed list of overrides. Available options are 'url', 'repository', 'username', and 'password'.  
  [--ssl-verify], [--no-ssl-verify]           # Set to false to disable SSL Verification.
                                              # Default: true

Out of these, the --database-name, --database-credentials, --database-host, and --database-port is not used. The code needs to be updated to:

  1. Remove these options from the kpm help diagnostic command
  2. Remove these options from the code where they are referred

The --overrides=key:value and --ssl-verify options are also unused and need to be removed from the kpm help diagnostic command as well.