search

killbill / killbill-plugin-framework-java

Framework to write Kill Bill plugins
https://killbill.io
Apache License 2.0
9 stars 24 forks source link

Leverage plugin framework inside (test) catalog plugin #55

Open sbrossie opened 2 years ago

sbrossie commented 2 years ago

The current repo killbill-catalog-plugin-test is not using this repo as a base.

We should leverage all the new api POJOs (see https://github.com/killbill/killbill-plugin-framework-java/issues/54) and stop pulling the classes from the killbill repo, i.e remove this dependency.

However, such dependency is also used to deserialize the XML catalog, by leveraging all the JAXB annotation. Perhaps instead we could use as a source JSON catalog files (see https://killbill.github.io/slate/#catalog-retrieve-the-catalog-as-json to extract such catalog json), and from the json data write a json parser leveraging jackson and the new api POJOs from this repo.

sbrossie commented 2 years ago

Note that we could simplify the catalog plugin:

  1. Remove support for harcdoded large catalog
  2. As a start, check-in a json catalog in the resource, and use this.
sbrossie commented 2 years ago

This work has been done as part of catalog-plugin-test PR.