search

killbill / killbill-plugin-framework-ruby

Framework to write Kill Bill plugins in Ruby
http://killbill.io
8 stars 11 forks source link

Handle ActiveMerchant network errors #44

Closed pierre closed 9 years ago

pierre commented 9 years ago

See https://github.com/Shopify/active_merchant/blob/master/lib/active_merchant/network_connection_retries.rb#L21-L34.

Currently, we throw a 500, which results in a PLUGIN_FAILURE. While the state is what we want, we should handle the error gracefully.

pierre commented 9 years ago

Fixed by https://github.com/killbill/killbill-plugin-framework-ruby/commit/27b2dc88f47eaa5144271c6fefa1611ae66dfb8b.