killbill / killbill-plugin-framework-ruby

Framework to write Kill Bill plugins in Ruby
http://killbill.io
8 stars 11 forks source link

Outofdate PlanPhaseSpecifier Wrapper #59

Open dergraf opened 7 years ago

dergraf commented 7 years ago

The PlanPhaseSpecifier wrapper uses the wrong Java interface. https://github.com/killbill/killbill-plugin-framework-ruby/blob/master/lib/killbill/gen/api/plan_phase_specifier.rb#L55 https://github.com/killbill/killbill-api/blob/master/src/main/java/org/killbill/billing/catalog/api/PlanPhaseSpecifier.java#L27

Is it possible that the wrapping code must be regenerated?

sbrossie commented 7 years ago

@dergraf Thanks for reporting the issue. This is indeed a bug in the code generation as indicated by the hack in that code here.

The easiest would be to change the PlanPhaseSpecifier to create the matching CTOR