Open ArekPiekarz opened 1 year ago
This was changed in #851
--verbose
to show all--verbose
to show upgradeable dependencies--verbose --verbose
to show all dependenciesBased on feedback about how noisy the output way. I punted on the bookkeeping for deciding what flag to show by just vaguely changing it to say "add --verbose
to show more dependencies". This is definitely something that would be good to improve to short-circuit and say --verbose --verbose
when its relevant.
For what it's worth, I never clued into needing to write --verbose
twice. When I saw the note saying to use --verbose
when I already was using it made me assume the feature was simply broken.
note: Re-run with
--verbose
to show more dependencies
I don't mind that this behaviour exists now that I'm aware of it, but the messaging could be improved to make it clear.
Running
cargo upgrade
with--verbose
flag produces the same content as without it. Only adding a second flag to create--verbose --verbose
makes a difference.I'm using cargo-edit-upgrade 0.12.0.
Steps to reproduce
Clone https://github.com/ArekPiekarz/rusty-tax-break
Checkout commit aade9dbd4701dcbc3c7a656e4d19ad1d8adb2b5c
Run
cargo upgrade -i --recursive
:It suggest to add
--verbose
flag, so let's do it.Run
git restore Cargo.lock Cargo.toml
Run
cargo upgrade -i --recursive --verbose
:As you can see, there is no difference in output - the
--verbose
flag has been ignored.Run
git restore Cargo.lock Cargo.toml
Add a second
--verbose
flag:Only now the verbosity has increased.