search

killercup / cargo-edit

A utility for managing cargo dependencies from the command line.
http://killercup.github.io/cargo-edit/
MIT License
3.09k stars 148 forks source link

Warning about ignoring workspace dependencies should not display when also upgrading workspace dependencies #898

Open joshtriplett opened 5 months ago

joshtriplett commented 5 months ago

When upgrading an entire workspace, cargo upgrade first shows Checking virtual workspace's dependencies and goes through those, and then goes through the crates in the workspace. When doing the latter, in verbose mode (which is necessary to see the list of crates that need upgrading) it'll print a warning like warning: ignoring cratename, source is workspace for every workspace dependency.

This warning would be useful if cargo upgrade was only running on a single package in the workspace, to explain why it doesn't upgrade workspace dependencies. However, in the case where cargo upgrade is already looking at workspace dependencies in the same run, it seems unnecessary.

Suggestion: remember if cargo upgrade looked at workspace dependencies before, and if so:

epage commented 5 months ago

Hadn't given the verbose output too much attention. Those messages should likely be switched to log messages.

I also haven't been giving cargo upgrade too much attention, instead encouraging effort towards cargo update --breaking which is now available in nightly