killercup / convey

A Rust create for outputting information and log messages for humans and machines
https://docs.rs/convey
Apache License 2.0
39 stars 5 forks source link

Allow nested span with inherited styles #24

Open killercup opened 5 years ago

killercup commented 5 years ago

It's not possible to have nested spans that inherit the parent's styles. One migth expect this however:

What do you think? Is this a good idea or not?


This is because of this reset call:

https://github.com/killercup/output-rs/blob/abbe3f145954358457bf542af207784324e39290/src/components/span.rs#L110

It might make sense to call this here instead/additionally:

https://github.com/killercup/output-rs/blob/abbe3f145954358457bf542af207784324e39290/src/lib.rs#L75-L78