change json file fn to appended to file

killercup / convey

A Rust create for outputting information and log messages for humans and machines

https://docs.rs/convey

Apache License 2.0

39 stars 5 forks source link

change json file fn to appended to file #7

Closed killercup closed 5 years ago

killercup commented 5 years ago

Right now it's just calling File::create, I assume we need to use OpenOptions.

[x] json::file("foo.log") creates foo.log if it doesn't exist
[x] json::file("foo.log") doesn't truncate foo.log if it does exist
[x] If foo.log exists, output::new().add_target(json::file("foo.log")?).print(text("hello world!")) appends "hello world" to it.
[x] If the file exists but has no trailing newline, a newline is added first so everything we write starts on a new line

Redrield commented 5 years ago

Could you elaborate on what's needed here? Do you want it to append to the file if it exists? (I'd be interested in working on this but I want to make sure I know what's wanted)

killercup commented 5 years ago

Hi! Yes, exactly. If the file exists, append to it, otherwise create it. If tried to make this a bit clearer in teh description above.

If you have any questions, don't hesitate to ask! Also, this project is in a very early stage, but I tried to write issues for things I know need to be addressed in any case.