search

killercup / grock

Grock converts your nicely commented code into a gorgeous documentation where comments and code live happily next to each other.
http://killercup.github.io/grock/
MIT License
38 stars 13 forks source link

Support 'whitespace-after-token' option from Groc #11

Closed novemberborn closed 10 years ago

novemberborn commented 10 years ago

Without it, JSHint directives like /*jshint validthis:true*/ show up in the documentation.

killercup commented 10 years ago

Thanks! This seems like a quite useful option.

Could you maybe at a test for this option? Just two cases would be enough. I know the tests are quite limited at the moment, but since the components I copied from groc are quite complex, I'd like to have at least a bit of reassurance that my next attempt to refactor something doesn't break this.

By the way, the Travis the build failed not because your PR broke any tests but because it couldn't publish to my gh-pages branch.

killercup commented 10 years ago

Oh, and if you could update the CLI help output in the Readme – that would be amazing.

novemberborn commented 10 years ago

Could you maybe at a test for this option? Just two cases would be enough.

Heh, I missed the seperator_spec originally. Added a test there. Not sure how to test that generator passes the correct options to splitCodeandComments which then has to forward to seperator.

Oh, and if you could update the CLI help output in the Readme – that would be amazing

Updated, it was missing several other options.

novemberborn commented 10 years ago

BTW seperator is misspelled in the code.

killercup commented 10 years ago

Thanks a lot! I'll merge this right now.

Yeah, I've seen it misspelt a few times as well, but it never seemed important enough to track down every occurrence and correct it… Maybe I'll just start calling it Seperatr and tell people it's one of those obscure Web2.0 technologies that nobody remembers.

novemberborn commented 10 years ago

Coolio!

novemberborn commented 10 years ago

Hey @killercup, could you push this to NPM?

killercup commented 10 years ago

Sure, I just didn't have time last weekend.

Am 18.03.2014 um 17:17 schrieb Mark Wubben notifications@github.com:

Hey @killercup, could you push this to NPM?

— Reply to this email directly or view it on GitHub.

killercup commented 10 years ago

It's up: NPM, GitHub Release