Optional bits for giftwrap

[mathstuf]

I like the idea, but it'd be nice if some things were optional, such as rustfmt (there are still bugs with it for some patterns; I need to collect them and file bugs), CI (not everyone uses CI that has artifacts in the repo, so some way to say "done externally" would be great), and potentially other things (not everyone uses git, so .gitignore).

[killercup]

I actually want cargo giftwrap to be pretty opinionated. I don't want it to have a configuration as it's meant to be simple enforce conventions. It is of course not a requirement to follow every one of its suggestions if you feel like you know better.

How about making things conditional instead? I didn't really write about it, but here is what I imagine:

• If there is a .git/config with ≥ 1 remotes, then the repository field in Cargo.toml needs to be set to one of these remotes
• If the repository is set to a public Github URL, a known CI tool needs to be used.
• If a CI tool is used and its badge can be set in Cargo.toml, it needs to be set in Cargo.toml

And, more controversially:

• If you don't want to use rustfmt, you need to add #![rustfmt_skip] to you crate

[mathstuf]

Those sound good to me.

And I do use rustfmt, but I do not apply all of its changes (they're usually issues with indentation mismatches, all of them bugs).

[killercup]

I personally hate visual indentation for most things 😄

Am 02.02.2017 um 15:00 schrieb Ben Boeckel notifications@github.com:

Those sound good to me.

And I do use rustfmt, but I do not apply all of its changes (they're usually issues with indentation mismatches, all of them bugs).

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[mathstuf]

Yeah, but this is kind of stuff I'm talking about:

Annoying, the arguments are related:

     let commit = ctx.git()
         .arg("commit")
         .arg("--allow-empty")
-        .arg("-m").arg("root commit")
+        .arg("-m")
+        .arg("root commit")
         .output()
         .unwrap();

bugs:

             result.add_error(format!("commit {} is a known-bad commit that was removed from the \
                                       server.",
-                                     commit.sha1_short))
+                                   commit.sha1_short))

[killercup]

Yeah, I agree. The second one should be

result.add_error(format!(
    "commit {sha} is a known-bad commit that was removed from the server.",
    sha = commit.sha1_short,
))

or I'm not gonna be happy…

(Aside from that, you should probably use the git2 crate instead of git's cli. Oh, and can you use .args(&["-m", "root commit"]) or something like that?)

[mathstuf]

libgit2 doesn't do allow all the things we need that the git command can do (at least it couldn't last I checked).

[mathstuf]

Yeah, no git update-index equivalent in the C API that I see.

[killercup]

(No activity for ≥30 days, closing)