search

killercup / trpl-ebook

UNMAINTAINED
http://killercup.github.io/trpl-ebook/
478 stars 56 forks source link

Reference points to incorrect URL #14

Closed cers closed 9 years ago

cers commented 9 years ago

In http://doc.rust-lang.org/book/conditional-compilation.html, the reference "[features] section" links to

http://doc.crates.io/manifest.html#the-[features]-section

But the PDF links to

http://doc.crates.io/manifest.html#the- {[}features{]}- section
cers commented 9 years ago

This is on page 78 of the A4 PDF

killercup commented 9 years ago

Thanks!

I'm quite sure that [ and ] are not valid characters in a URL, so maybe that's why LaTeX doesn't like it. I'll investigate.

cers commented 9 years ago

I'm slightly uncertain as to the rules for the hash part of a url, but in general they are reserved for a specific purpose (not this one), and when not used for that purpose they should be encoded such that the url appears as

http://doc.crates.io/manifest.html#the-%5Bfeatures%5D-section
killercup commented 9 years ago

Indeed. I think it's best to just escape this for now (using %5B like you did) and also fix it upstream.

This points to another issue though: On the crates doc page, there is an element with an obviously invalid ID.

cers commented 9 years ago

HTML5 (which the page uses) actually permits this, indeed an ID must just be at least one character, and not include any spaces.

killercup commented 9 years ago

Interesting. And one less thing to report and worry about, I guess :)

I replaced the URL and opened rust-lang/rust#25857 to change it upstream as well.

I also pushed a new build of all version to the gh-pages branch.