search

killercup / trpl-ebook

UNMAINTAINED
http://killercup.github.io/trpl-ebook/
478 stars 56 forks source link

Add replacement rules for cross-book links #19

Closed Gankra closed 9 years ago

killercup commented 9 years ago

Thanks. Do you know of any other subdirs on doc.rust-lang.org that we should map?

Gankra commented 9 years ago

I was actually wondering if we should just blindly remap ../ to doc.rust-lang.org

killercup commented 9 years ago

Hm, I think that'd be a bit too drastic. This would basically break relative links when using subdirectories in books.

(I foresee a glorious future for this where a CLI parameter can either tell this binary where the book files are or where a config file with all the paths and redirects are. I also foresee that I'll not have much time to add this in the next weeks, though :/)

Gankra commented 9 years ago

FWIW the books don't use subdirectories at all, and rustbook is actually broken if you do. The "next/prev" links will only jump between the top-level README's and not the individual sections.

On Tue, Jul 14, 2015 at 10:10 AM, Pascal Hertleif notifications@github.com wrote:

Hm, I think that'd be a bit too drastic. This would basically break relative links when using subdirectories in books.

(I foresee a glorious future for this where a CLI parameter can either tell this binary where the book files are or where a config file with all the paths and redirects are. I also foresee that I'll not have much time to add this in the next weeks, though :/)

— Reply to this email directly or view it on GitHub https://github.com/killercup/trpl-ebook/pull/19#issuecomment-121311184.

killercup commented 9 years ago

rustbook is actually broken if you do.

Well, then it doesn't matter (wen can change it when rustdoc begins supporting it). Feel free to send a PR :)