killercup
commented
8 years ago Thanks for the PR!
I'll have a look at the actual changes later, and see if I can merge the fixes.
As you may have seen, trpl-ebook is pretty inactive right now. Recently, some people started doing some work over at mdBook, though, with the goal to have that application render stuff using LaTeX. mdBook is an actual binary that works like rustbook and is configured by metadata (IIRC), so that might be of interest to you.
Have a great evening, Pascal
Am 26.01.2016 um 23:35 schrieb Michael Pankov notifications@github.com:
Hi!
I would like to start by saying I don't indend this PR to be merged in your repository and rather discuss some issues and potential solutions so maybe we could collaborate on them.
As you might know, we, over at @ruRust, have translated the TRPL in Russian. We also provided ebook versions of the book with Calibre. Unfortunately, the story was less than smooth, so now I'm looking at trpl-ebook to use it in our infrastructure instead. Hope you don't mind!
This PR illustrates the changes that were needed in order to get more-or-less working translation. The first commit is just import of our data and can be ignored. Some of the rest, I believe, are legitimate fixes (d080714 , 2372488 , 337f119). They could be cherry-picked and merged if you agree they are necessary and good ones. I can provide details why did I do them.
Then, there are changes in code due to some resources being hard-coded in sources: 3914c1b , c47bc94#diff-ef03e76469e3c2afd2e0018d57dccce8L1 . These parts could be further factored out to metadata.
Then, I think it makes sense to make trpl-ebook a proper binary crate, that could be used as an external program - so that translators pointed it to metadata and content, and it would convert everything. It also happens to me we don't want conversion to some formats (letter) and want conversion to some others (MOBI).
I understand issues are better for tracking work, I just want to hear your overall opinion first. I could file proper issues later if we decide they are needed.
So, what I, on behalf of ruRust community, would like to know, is whether you're interested in these changes, will accept new proper PRs, and ready to further discuss the details.
Regards, Michael
You can view, comment on, or merge this pull request online at:
https://github.com/killercup/trpl-ebook/pull/28
Commit Summary
• Replace content • Use Cyrillic fonts • Rename "Introduction" • Use $language$ as in metadata • Fix "undefined control sequence" • Fix "Option clash for package fontspec." • Translate metadata • Fix broken link File Changes
• M lib/template.tex (11) • M src/convert_book/markdown.rs (2) • M src/convert_book/options.rs (2) • M trpl/README.md (230) • M trpl/SUMMARY.md (141) • M trpl/advanced-linking.md (128) • M trpl/associated-constants.md (22) • M trpl/associated-types.md (96) • M trpl/attributes.md (39) • M trpl/benchmark-tests.md (100) • M trpl/bibliography.md (28) • M trpl/borrow-and-asref.md (75) • M trpl/box-syntax-and-patterns.md (50) • M trpl/casting-between-types.md (61) • M trpl/choosing-your-guarantees.md (523) • M trpl/closures.md (341) • M trpl/comments.md (59) • M trpl/compiler-plugins.md (264) • M trpl/concurrency.md (326) • M trpl/conditional-compilation.md (51) • M trpl/const-and-static.md (71) • M trpl/crates-and-modules.md (394) • A trpl/custom-allocators.md (172) • M trpl/deref-coercions.md (79) • M trpl/dining-philosophers.md (602) • M trpl/documentation.md (427) • M trpl/drop.md (53) • M trpl/effective-rust.md (13) • M trpl/enums.md (73) • M trpl/error-handling.md (2235) • M trpl/ffi.md (551) • M trpl/functions.md (255) • M trpl/generics.md (113) • M trpl/getting-started.md (619) • M trpl/glossary.md (71) • M trpl/guessing-game.md (0) • I trpl/if-let.md (0) • I trpl/if.md (0) • I trpl/inline-assembly.md (0) • I trpl/intrinsics.md (0) • I trpl/iterators.md (0) • I trpl/lang-items.md (0) • I trpl/learn-rust.md (0) • I trpl/lifetimes.md (0) • I trpl/loops.md (0) • I trpl/macros.md (0) • I trpl/match.md (0) • I trpl/method-syntax.md (0) • I trpl/mutability.md (0) • I trpl/nightly-rust.md (0) • I trpl/no-stdlib.md (0) • I trpl/operators-and-overloading.md (0) • I trpl/ownership.md (0) • I trpl/patterns.md (0) • I trpl/primitive-types.md (0) • I trpl/raw-pointers.md (0) • I trpl/references-and-borrowing.md (0) • I trpl/release-channels.md (0) • I trpl/rust-inside-other-languages.md (0) • I trpl/slice-patterns.md (0) • I trpl/strings.md (0) • I trpl/structs.md (0) • I trpl/syntax-and-semantics.md (0) • I trpl/testing.md (0) • I trpl/the-stack-and-the-heap.md (0) • I trpl/trait-objects.md (0) • I trpl/traits.md (0) • I trpl/type-aliases.md (0) • I trpl/ufcs.md (0) • I trpl/unsafe.md (0) • I trpl/unsized-types.md (0) • I trpl/variable-bindings.md (0) • I trpl/vectors.md (0) • I trpl_meta.yml (0) Patch Links:
• https://github.com/killercup/trpl-ebook/pull/28.patch • https://github.com/killercup/trpl-ebook/pull/28.diff — Reply to this email directly or view it on GitHub.
Hi!
I would like to start by saying I don't indend this PR to be merged in your repository and rather discuss some issues and potential solutions so maybe we could collaborate on them.
As you might know, we, over at @ruRust, have translated the TRPL in Russian. We also provided ebook versions of the book with Calibre. Unfortunately, the story was less than smooth, so now I'm looking at trpl-ebook to use it in our infrastructure instead. Hope you don't mind!
This PR illustrates the changes that were needed in order to get more-or-less working translation. The first commit is just import of our data and can be ignored. Some of the rest, I believe, are legitimate fixes (https://github.com/killercup/trpl-ebook/commit/d08071471964ed196301746f6433fc6618994465 , https://github.com/killercup/trpl-ebook/commit/2372488f45218320cfd36807e8174c5937366ef2 , https://github.com/killercup/trpl-ebook/commit/337f119ee22d8998d2473ae27e5e1d0f7c42db89). They could be cherry-picked and merged if you agree they are necessary and good ones. I can provide details why did I do them.
Then, there are changes in code due to some resources being hard-coded in sources: https://github.com/killercup/trpl-ebook/commit/3914c1b32e01c41f56802ad2d52c6194efe39e4d , https://github.com/killercup/trpl-ebook/commit/c47bc949a1757fd75a687ad1a9b69e169f051817#diff-ef03e76469e3c2afd2e0018d57dccce8L1 . These parts could be further factored out to metadata.
Then, I think it makes sense to make
trpl-ebooka proper binary crate, that could be used as an external program - so that translators pointed it to metadata and content, and it would convert everything. It also happens to me we don't want conversion to some formats (letter) and want conversion to some others (MOBI).I understand issues are better for tracking work, I just want to hear your overall opinion first. I could file proper issues later if we decide they are needed.
So, what I, on behalf of ruRust community, would like to know, is whether you're interested in these changes, will accept new proper PRs, and ready to further discuss the details.
Regards, Michael