search

killerducky / killer_mortal_gui

15 stars 11 forks source link

Occasional misplacement of cards #2

Closed Dilaen closed 8 months ago

Dilaen commented 9 months ago

When I was using Mortal to review my game as usual, I surprisingly found that the GUI changed to this new "KillerDucky" style! First, I must thank you for your work on making Mortal's GUI more interesting (or "NAGA-like" if I may say). I couldn't wait to try this new GUI and seemed to find a minor bug——in some cases, a card might appear in a wrong position. Let me illustrate it with the pictures below.

  1. Here I chose to "chi" the 6p from my left player using 4p0p, which is different from Mortal's choice.
微信图片_20240302001642
  1. After I clicked "Next" button, the 6p in my hand suddenly jumped to the rightmost position. However, it was supposed to stay on the right of and next to 5p!
微信图片_20240302001721-2
  1. After I cut "haku" next turn, the 6p in my hand jumped back to where it was supposed to be and stayed in the correct position till the end of this round.
微信图片_20240302002316

By the way, the problem described above doesn't appear on the replay viewer of "Classic" UI.

killerducky commented 9 months ago

Thanks for your report. I noticed it too and have a fix locally, it will be fixed in the next release.

killerducky commented 9 months ago

Fixed by https://github.com/killerducky/killer_mortal_gui/commit/86889d508e59fe450c92424ffef7505d5bdb9940 Not released yet.