killerducky / killer_mortal_gui

15 stars 11 forks source link

feat(i18n-ko) Add Korean translation #9

Closed cjeon closed 8 months ago

cjeon commented 9 months ago

Related to #1. Thank you for the kind local execution manual. I'm certain that this project would benefit world-wide mahjong players 👍

Below are the break-down of commits & the copy-paste of the commit messages.

45e533dc89927352b87a36e923eec15a740645f0

Changed the event listener type of the langSelect element from click to change as click is triggered before the actual selection and change is triggered after the user's selection. Added missing () to function call updateState.

453c0d06e16e2fccbc4e281d2df09a7c691c7baf

After introducing i18n, the connectUI function can be called multiple times. Introduced simple initialization so that the old contents of the aboutBody is properly removed.

46c083b65afa4c93147eb0fa526fa2517798bf16

translations.js: added Korean translation according to Korean Mahjong League's official translations. (https://kml.or.kr/?page_id=62&uid=950&mod=document)

index.js: changed some order in code to reflect the language's natural order. This might not be optimal architecture (from the perspective of separation of concern) but it works for now.

killerducky commented 8 months ago

Thanks!