search

killergerbah / asbplayer

Browser-based media player and Chrome extension for subtitle sentence mining
MIT License
542 stars 69 forks source link

Recording starts from wrong point #346

Closed erikji closed 7 months ago

erikji commented 10 months ago

screencast-bpconcjcammlapcogcnnelfmaeghhagj-2024.01.04-17_20_32.webm

Using the latest version, though I just updated Chrome. The recording starts a few seconds earlier than when it should. (In the video, it actually ends up recording the previous subtitle.)

killergerbah commented 10 months ago

Hi @erikji , did this problem just start happening? I've seen reports of problems in the past of precise seeking being kind of broken on Netflix's video player, particular for slower/older computers.

erikji commented 10 months ago

Yes, it just started. The computer I'm using is a 2016 MacBook if that helps.

killergerbah commented 10 months ago

@erikji Do you mind sharing the name of the video you're watching?

erikji commented 10 months ago

Switched

I also tried it on Stand By Me Doraemon which had the issue as well. The program seems to get 'stuck' to a certain timestamp sometimes.

erikji commented 10 months ago

I just tried again with the old version of asbplayer. It appears to be an issue with subtitle offset that affects recording but not subtitle display, if that helps.

GriefBacon commented 7 months ago

I'm having a similar issue on Brave browser.

Using a Macbook Air M1 Both ASB player and Brave browser are up-to-date.

I've tried both on Dungeon Meshi and Monster. It seems to be grouping subtitle tracks in two's.

killergerbah commented 7 months ago

For some reason (possibly CPU core count) Netflix does not allow precise seeking on some devices by default. A speculative fix for this is implemented (see Discord server for snapshot release).