Condensed Option to skip music and closed captions

killergerbah / asbplayer

Browser-based media player and Chrome extension for subtitle sentence mining

MIT License

427 stars 48 forks source link

Open CroakingToadElf opened 3 weeks ago

CroakingToadElf commented 3 weeks ago

Hey,

thanks a lot for your hard work, this is easily the best tool for learning Japanese and I am very grateful!

I have the following request:

Could you add an option to the "condensed" mode that skips closed captions (anything in parentheses) and music. Something like this:

"filtered_characters": "♩♪♫♬～〜", "filter_parentheses": true,

I took this from the config.json of a tool called "Condenser": https://github.com/ercanserteli/condenser

Thank again and have a wonderful day.

killergerbah commented 3 weeks ago

@CroakingToadElf This can already be achieved using the subtitle filter regex settings. If those subtitles are filtered out, asbplayer will skip them automatically in condensed mode. See https://github.com/killergerbah/asbplayer?tab=readme-ov-file#filtering-subtitle-text