killergerbah / asbplayer

Browser-based media player and Chrome extension for subtitle sentence mining
MIT License
436 stars 48 forks source link

Support for streaming video with extension on Kiwi Browser on Android #438

Open keineahnungking opened 1 month ago

keineahnungking commented 1 month ago

Currently when I install the extension on Kiwi Browser on Android and open the extension, it just opens a settings popup in a new tab but doesn't give me the option to select subtitles.

killergerbah commented 1 month ago

Opening the extension from the webpage itself (menu -> extensions -> asbplayer) should open up the subtitle track selector.

keineahnungking commented 4 weeks ago

I'm not sure what you mean by "the webpage itself". Do you mean the website I am watching a video on like YouTube for example? When I'm doing that and then clicking on the three dot menu in the top right and then on asbplayer in the list of extensions, it just opens the extension settings in a new tab and not a subtitle selector.

killergerbah commented 4 weeks ago

Yeah that's what I mean. I think I understand the issue now, though. Basically asbplayer isn't good at detecting tablets. I have a speculative fix for this.

keineahnungking commented 4 weeks ago

I have this issue with Kiwi Browser on both my phone and my tablet. I don't have this issue with Firefox on Android on both my phone and my tablet. I believe the issue is with Kiwi Browser.

killergerbah commented 4 weeks ago

Interesting Our of curiosity are you using the desktop version of the website?

keineahnungking commented 4 weeks ago

I tried on YouTube with both mobile and desktop version and both didn't work

killergerbah commented 4 weeks ago

Can you try this build? asbplayer-extension-1.3.0-chromium.zip

killergerbah commented 3 weeks ago

@keineahnungking I released another version of the extension with a possible fix. Let me know if you're still having the issue.

keineahnungking commented 3 weeks ago

The subtitle selector pops up now but I am unable to open the settings and unable to open the dialog to mine a card. The buttons in the overlay don't do anything

killergerbah commented 2 weeks ago

You can open settings from the extensions manager. I am surprised that the buttons in the overlay do nothing, need more info to debug.