search

killergerbah / asbplayer

Browser-based media player and Chrome extension for subtitle sentence mining
MIT License
504 stars 65 forks source link

Toggle subtitles keyboard shortcut no longer works after mining #479

Closed zuckyyyy closed 3 weeks ago

zuckyyyy commented 2 months ago

I decided to start using the toggle subtitles shortcut and I noticed that after mining, you have to click the video player screen again in order for the keyboard shortcut to work. At the same time this happens, other shortcuts such as play/toggle still work.

killergerbah commented 1 month ago

@zuckyyyy Is this issue still happening? Is this happening with local video on the asbplayer website? What mining flow are you using - for example update last card or the Anki export dialog?

zuckyyyy commented 4 weeks ago

It stopped happening when the fullscreen issue came up. Was using the local player, both update last card and the export dialog

killergerbah commented 3 weeks ago

I haven't been able to reproduce this and it looks like it's not happening for @zuckyyyy anymore. Feel free to re-open if that's not true.