search

killergerbah / asbplayer

Browser-based media player and Chrome extension for subtitle sentence mining
MIT License
534 stars 69 forks source link

Mine current subtitle shortcut is only copying current subtitle #548

Open madisonruppert opened 2 weeks ago

madisonruppert commented 2 weeks ago

Before submitting an issue check out the common issues section of the README: https://github.com/killergerbah/asbplayer?tab=readme-ov-file#common-issues

What is the issue and how what do you do to make it happen When I do the shortcut hotkey for mining the current subtitle, it just copies it to the clipboard. I have it set to export to Anki. Clicking the mine button on the overlay or sidebar works as expected. What browser? Brave 1.71.114 Is it happening with local video or streaming video? Streaming (all platforms) If the issue is happening with streaming video, what version of the extension are you using? v1.5.0 If the issue is happening with streaming video, on what website(s) is the issue happening? Prime Video, Netflix, YouTube.

killergerbah commented 1 week ago

Which shortcut are you using? You need to use the "mine current subtitle and open Anki dialog" shortcut.

madisonruppert commented 1 week ago

Yes, as I mentioned in the original post, that shortcut works fine. However, I’m looking for a one-click shortcut that will just mine the current subtitle without opening any dialog boxes. Since there is no way to do that, I’m currently having to use an external program to map a button click to a controller with a precisely placed cursor so I can click through the dialog box. Kind of a pain when it seems like there should be a shortcut to just mine when you can do it by clicking the overlay or the sidebar. Hope that’s clear, thanks!

On Fri, Oct 25, 2024 at 3:44 PM Raphael-Joel Lim @.***> wrote:

Which shortcut are you using? You need to use the "mine current subtitle and open Anki dialog" shortcut.

— Reply to this email directly, view it on GitHub https://github.com/killergerbah/asbplayer/issues/548#issuecomment-2437410253, or unsubscribe https://github.com/notifications/unsubscribe-auth/BI5UJKALKXG7VWVLJIB24NDZ5IKXNAVCNFSM6AAAAABQJPCN52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZXGQYTAMRVGM . You are receiving this because you authored the thread.Message ID: @.***>

killergerbah commented 1 week ago

I see, I'm guessing you have the default "click to mine" action set to "export to Anki." If that's the case, I take your request to mean that you would like a keyboard shortcut that triggers the same behavior. Is that accurate?

This is actually a pretty non-standard use of asbplayer since most users would like to fill in some more card details other than what asbplayer can provide automatically. Originally, "export to Anki" was used to implement one-click mining with dictionary definition explained here. However, your use-case provides some motivation for implementing a new keyboard shortcut.

madisonruppert commented 1 week ago

Yes you hit the nail on the head. I have the one-click definition mining set up via Yomitan (thanks to them adding some rudimentary Hindi support!) but sometimes I also like to mine whole sentences Subs2SRS style. It would be extremely appealing to be able to do that with a single click. The ability to add multiple setting profiles means I could easily switch setups for both uses.

Thanks!

Madison Ruppert

On Fri, Oct 25, 2024 at 6:01 PM Raphael-Joel Lim @.***> wrote:

I see, I'm guessing you have the default "click to mine" action set to "export to Anki." If that's the case, I take your request to mean that you would like a keyboard shortcut that triggers the same behavior. Is that accurate?

This is actually a pretty non-standard use of asbplayer since most users would like to fill in some more card details other than what asbplayer can provide automatically. Originally, "export to Anki" was used to implement the one-click mining with dictionary definition explained here https://github.com/killergerbah/asbplayer?tab=readme-ov-file#one-click-mining-flow. However, your use-case provides some motivation for implementing a new keyboard shortcut.

— Reply to this email directly, view it on GitHub https://github.com/killergerbah/asbplayer/issues/548#issuecomment-2437656266, or unsubscribe https://github.com/notifications/unsubscribe-auth/BI5UJKHDAM4Q3SYONWEKWVTZ5I2ZJAVCNFSM6AAAAABQJPCN52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZXGY2TMMRWGY . You are receiving this because you authored the thread.Message ID: @.***>