search

killergerbah / asbplayer

Browser-based media player and Chrome extension for subtitle sentence mining
MIT License
528 stars 69 forks source link

asbplayer website no longer captures exact frame #549

Open UmbralCosmos opened 1 week ago

UmbralCosmos commented 1 week ago

Before submitting an issue check out the common issues section of the README:

The problem only involves the mined picture.

On the website, using shift+ctrl+x to capture a moment and create an anki diologue, the picture is no longer the exact moment but a single frame for a set amount of time.

For example, I can only get 1 specific frame within 1 second, preventing me from getting the exact picture I want.

This was not the case at least a few months ago.

Chrome Version 130.0.6723.59 (Official Build) (64-bit)

Local video

UmbralCosmos commented 1 week ago

It seems this was addressed but I am still having this problem.

https://github.com/killergerbah/asbplayer/issues/238#issuecomment-1537161090

killergerbah commented 5 days ago

Is the problem you're experiencing that the 'manually take screenshot' shortcut does not work?

UmbralCosmos commented 5 days ago

Is the problem you're experiencing that the 'manually take screenshot' shortcut does not work?

No, "you're right, it looks I broke the "current frame" behavior at some point. I've pushed the fix for that; let me know what you think." is the comment I referenced.

When I try to mine the current subtitle, the captured image is not of the frame I'm on. It is the frame at the beginning of the subtitle.

The "manually take screenshot" doesn't work either but I never had any need of it before now anyways.

killergerbah commented 5 days ago

@UmbralCosmos Unfortunately, I'm unable to reproduce the issue. Are you using https://killergerbah.github.io/asbplayer/ with the latest version of the extension (1.5.0)?

UmbralCosmos commented 5 days ago

@killergerbah I am not using the extension. Just the website. Only use it with local videos.

UmbralCosmos commented 3 hours ago

@killergerbah It seems this occurs on some types of videos. I have 3 series in .mkv and this issue occurs in only one of them. Having subtitles or not doesn't seem to affect anything. Would you like me to send the video files?