killme2008 / xmemcached

High performance, easy to use multithreaded memcached client in java.
http://fnil.net/xmemcached
Apache License 2.0
757 stars 281 forks source link

Refactor: Rename AWSElastic to AutoDiscovery for AWS and GCP compatibility #143

Closed hazdikk closed 9 months ago

hazdikk commented 9 months ago

This PR includes a refactor of the codebase to improve compatibility between AWS and GCP Auto Discovery. Previously, the code was specifically named and designed for AWS ElasticCache. However, after careful review and testing, it was found that AWS ElasticCache and GCP Auto Discovery work in the same way.

The commands and responses for both services are identical, which means we can use the same methods for both. This refactor renames all instances of AWSElastic to AutoDiscovery to reflect this compatibility and to avoid confusion for users.

Users can now use the same AutoDiscovery methods for both AWS and GCP Auto Discovery.

For more information on how to use AWS Auto Discovery, please refer to the AWS Documentation.

For more information on how to use GCP Auto Discovery, please refer to the GCP Documentation.

Please note that this refactor does not change the functionality of the methods, but simply renames them for clarity and improved compatibility.

Note: The GitHub Wiki has not been updated to reflect these changes as I am currently unsure of how to do so. Any assistance or guidance on this would be appreciated.

killme2008 commented 9 months ago

It's a good idea. But i don't like the breaking change, can we provide some way to keep compatible with previous versions, and make the AWSElasticXXXX deprecated?

hazdikk commented 9 months ago

Sure, will update later, thank for the input

hazdikk commented 9 months ago

Updated