search

killme2008 / xmemcached

High performance, easy to use multithreaded memcached client in java.
http://fnil.net/xmemcached
Apache License 2.0
757 stars 280 forks source link

Remove duplicate MemcachedException on fetch0 method #64

Closed IluckySi closed 7 years ago

IluckySi commented 7 years ago

hi, my friend:

I find a small question in com.googlecode.xmemcached, the following method has two MemcachedException. 

 net.rubyeye.xmemcached.XMemcachedClient
@SuppressWarnings("unchecked")
private final <T> Object fetch0(final String key, final byte[] keyBytes,
        final CommandType cmdType, final long timeout,
        Transcoder<T> transcoder) throws InterruptedException,
        TimeoutException, MemcachedException, MemcachedException {

Maybe this is no effetc for use it. But when I user bytebuddy(A bytecode manipulation framework, like asm javasist) to monitor the application, I encountered a problem , in bytebuddy not allow one method has same exception. I have given a issue to bytebuddy #https://github.com/raphw/byte-buddy/issues/347

I also hope com.googlecode.xmemcached can get optimized to obtain better development. Thank you very much!

killme2008 commented 7 years ago

Hmm.. thanks for your PR. It's a mistake here.

killme2008 commented 7 years ago

Released xmemcached 2.4.0, but it may take sometime to be sync into central repo.