killy971 / codecov-haskell

codecov.io support for haskell code coverage with hpc
http://hackage.haskell.org/package/codecov-haskell
BSD 3-Clause "New" or "Revised" License
29 stars 16 forks source link

Fix broken build of performWithRetry #14

Closed dahlia closed 2 years ago

dahlia commented 7 years ago

Fixes #13.

It was broken due to retry-0.7's changing of retrying function.

dahlia commented 7 years ago

A job on GHCVER=7.6.3 is broken, but it seems it has been so.

atodorov commented 7 years ago

+1 I also need this.

@guillaume-nargeot can we get this merged and a new package version published ?

dahlia commented 6 years ago

@guillaume-nargeot Could you review this?

NickSeagull commented 6 years ago

So this is not maintained anymore?

creichert commented 6 years ago

You can likely drop support for 7.6 at this point and add support for GHC 8's.

If you want, you can use this drop-in circleci config: https://gist.github.com/creichert/efb84716d628c431e827ff95289b6aa7

It will test lts-9 to lts-12 and has a nightly resolver test too. All you would need to do is change the "package.yaml" to your cabal file if not using hspec.

I'd be happy to submit a PR. I think it's important to get this project up-to-date because it's practically the only viable option for coverage in Haskell.

Additionally, we should enable reports for this repo and upload them. Do you want PRs?

iustin commented 4 years ago

Friendly ping. I'd like to use this as well, but is still broken. Guillaume, do you intend to update this?

DamienCassou commented 3 years ago

Same for me.

dahlia commented 2 years ago

I give up this old pull request. 👋🏼 To whom long-waited this to be merged: use the hpc-codecov package instead, which is actively maintained.