search

killy971 / hpc-coveralls

coveralls.io support for haskell code coverage with hpc
http://hackage.haskell.org/package/hpc-coveralls
BSD 3-Clause "New" or "Revised" License
60 stars 20 forks source link

List Paths_hpc_coveralls in other-modules #59

Closed RyanGlScott closed 8 years ago

RyanGlScott commented 8 years ago

Not doing so causes the linker to get confused when hpc-coveralls is configured with --enable-executable-dynamic. This was also discovered in https://github.com/fpco/stackage/issues/1338.

Fixes #52.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 36.17% when pulling 77f24f759d5af3f7f83703b11bd57556bd0e1860 on RyanGlScott:master into acf1a879134112972ba05bc0dc478d3735229244 on guillaume-nargeot:master.

RyanGlScott commented 8 years ago

Ping?

killy971 commented 8 years ago

I'm really sorry I didn't notice your pull request! I will have a look at it today. On 2016年8月21日(日) at 23:11 Ryan Scott notifications@github.com wrote:

Ping?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/guillaume-nargeot/hpc-coveralls/pull/59#issuecomment-241259888, or mute the thread https://github.com/notifications/unsubscribe-auth/AABOE_PlGE33nvIHy4ZrcG-oY6mopYJiks5qiFyMgaJpZM4I4Uby .

RyanGlScott commented 8 years ago

Thank you!

killy971 commented 8 years ago

I've released the change in hpc-coveralls 1.0.6, is there a way for you to confirm that this version is now usable with your setup? (using the --enable-executable-dynamic option)

RyanGlScott commented 8 years ago

I can confirm it works, as noted here, using cabal configure --enable-executable-dynamic && cabal build and stack build --ghc-options=-dynamic.