"hpc-coveralls test" returns exit code 0 even on error

[nurpax]

In build https://travis-ci.org/nurpax/snaplet-sqlite-simple/builds/22389915, hpc-coveralls test hits an error due to a wrong current working dir. It prints an error and then exits with exit code 0, which fools Travis CI thinking everything worked fine.

The correct behavior would be to return a non-zero exit code in this case.

[killy971]

This can indeed be made to return a non-zero exit code, but anyway, Travis CI won't consider the build as failed because hpc-coveralls is executed as part of the after_script phase.

The purpose of this is to be not too intrusive, considering the possible problems still existing in this experimental version at the moment.

Travis CI would mark the build as failed if this was executed as part of the script phase.

Anyway, I don't think it should be too difficult to implement, so I'll have a look at it soon. Thanks for reporting this!

[killy971]

Fixed by 5507ed0054f73a4390da0c6455e645fba8747caf Will be released with v2.0.0

[killy971]

I just noticed that Travis doesn't display the exit code of commands run in the after_script phase, as only the commands run in the script are taken in consideration for determining if the build succeeded or failed.