search

kilmajster / ngrok-spring-boot-starter

🚀 Spring Boot tunneling with Ngrok made easy! No matter if you are using Windows, Mac OS X, Linux or even Docker - ngrok binary will be chosen automatically 🤖 so you don't need to care about environment changing etc. auto-configuration magic 🧙‍♂️
MIT License
125 stars 17 forks source link

Use @ConfigurationProperties instead of @Value for auto-completion #52

Closed s-frei closed 3 years ago

s-frei commented 3 years ago

Hey there,

just discovered your starter as I tought about exposing some ports using ngrok here and there, and I am glad there is something around :wink: And it works 👍

But I'd suggest to use configuration classes to have some auto-completion in the application configuration to make the experience using this starter even better and avoid the need to search for the statics.

If you'd like me to, I could provide that. Tell me what you think about that.

kilmajster commented 3 years ago

H2 @s-frei, thanks for your idea! It sounds good to me so if you got time feel free to open a MR. Ask here if you need any help 🙂

kilmajster commented 3 years ago

Released in https://github.com/kilmajster/ngrok-spring-boot-starter/releases/tag/0.3.6