search

kilmajster / ngrok-spring-boot-starter

🚀 Spring Boot tunneling with Ngrok made easy! No matter if you are using Windows, Mac OS X, Linux or even Docker - ngrok binary will be chosen automatically 🤖 so you don't need to care about environment changing etc. auto-configuration magic 🧙‍♂️
MIT License
125 stars 17 forks source link

Use local ngrok runtime if available #56

Closed juherr closed 1 year ago

juherr commented 3 years ago

Use local runtime, instead of downloading a new one.

kilmajster commented 3 years ago

I think it should already work this way.. And also if under runtime you mean ngrok binary file, then when you got it placed in some non standard location then ngrok.directory property, should work for you. If not could you please provide some more details about your case?

juherr commented 3 years ago

Sorry, I didn't give you enough context.

I'm using MacOS and I had installed ngrok thanks to brew. Then, ngrok CLI is available in the path:

❯ which ngrok
/usr/local/bin/ngrok
# link to
❯ ls /usr/local/Caskroom/ngrok/latest
ngrok

The starter downloaded another binary:

❯ ls ~/.ngrok2
ngrok       ngrok.yml

I think the starter should try using ngrok from the PATH before downloading another version.

BTW, it is not a big deal, just a little improvement in order to avoid some duplication.

kilmajster commented 1 year ago

Fixed in v0.7.0