search

kiln / flourish-sdk

The SDK for developing Flourish templates
Other
80 stars 16 forks source link

Source map warnings? #71

Open aendra-rininsland opened 2 years ago

aendra-rininsland commented 2 years ago

I keep getting sundry source map warnings in development, which might be part of the reason source maps are frequently wrong while developing. Any thoughts?

Screenshot 2021-09-21 at 17 30 52

robinhouston commented 2 years ago

Interesting! I think all these are part of the SDK implementation, and the issue is that the files reference sourcemaps (which don’t exist).

The sourcemap for your code ought to be loadable via the SDK from http://localhost:1865/script.js.map

aendra-rininsland commented 2 years ago

@robinhouston Ahhh interesting!! My guess is your npm publish script isn't including those, probably a pretty simple PR.

Edit: Nope, your build process for the site/ files is removing the sourcemaps, or not outputting them. You'll need to fix the sdk_clean and sdk Makefile targets as well. See below PR.