search

kilork / openid

OpenID Connect Rust Library
The Unlicense
61 stars 22 forks source link

[#17]: Allow to clone the client #18

Closed ctron closed 3 years ago

ctron commented 3 years ago

Closes #17

kilork commented 3 years ago

I want to merge it, but do have a question about backward compatibility. Should we include this in 0.8.1 or better to create next version 0.9.0?

ctron commented 3 years ago

Good question. Technically I think this change should be ok to go into a 0.8.1 version, as it only adds to the API. It doesn't require any new features from an implementor and keeps the API compatible with 0.8.0.

In a 1.x (or better post 0.x) release it would make sense to create a new minor release (e.g. 1.0 -> 1.1), as it would still be compatible using "1". However with 0.x, a change from 0.8 to 0.9 would make it incompatible.

Going for 0.9 might be a safer approach though.

Anyway, I am happy if you merge this and make a release :grinning: … thanks for taking care of this!

kilork commented 3 years ago

I think to be on the safe side better we do 0.9 version release. We still far away from 1.0 release, probably we need to start think about that we are missing to do so.