fix another sync/send issue

kilork / openid

OpenID Connect Rust Library

The Unlicense

61 stars 22 forks source link

fix another sync/send issue #20

Closed ctron closed 3 years ago

ctron commented 3 years ago

Found one more :) … after debugging for "a bit" :grin: .

It would be awesome if you could merge and release this! :heart:

kilork commented 3 years ago

Hey @ctron , with my pleasure. Can you tell, how you actually encountered this issue and how you managed to find a solution?

ctron commented 3 years ago

I was creating a trait using async_trait. I took me a while to figure out that the root case was this issue. Then I found in the existing code, in other locations, the explicit scoping and that comment. That worked for me.

kilork commented 3 years ago

Thank you! This probably means we can have an integration test to check we do not have such kind of problems. Something like minimal reproduction example to be on safe side. It should not really do anything other than compile successfully.