Allow Userinfo bools to be "true" and "false" strings.

kilork / openid

OpenID Connect Rust Library

The Unlicense

61 stars 22 forks source link

Allow Userinfo bools to be "true" and "false" strings. #6

Closed brianhv closed 3 years ago

brianhv commented 3 years ago

I'm using AWS Cognito, and its userInfo endpoint is returning string "true" or "false" values rather than real bools. This patch allows the crate to contend with that quirk.

I haven't tested this thoroughly (say, by trying providers that aren't AWS). I wanted to offer this proposal and see if it's reasonable. If you'd like me to do more due diligence, please let me know.

kilork commented 3 years ago

Hi, seems to be reasonable, I would try this with google openid and keycloak, I would update you on this. Sorry for the delay with the reply, spent some time outside of open source :(

kilork commented 3 years ago

Checked with Google OpenID, seems to work fine, merging. Thank you!