search

kiltjs / jqlite

Tiny JavaScript DOM query library that uses pure CSS selectors
MIT License
100 stars 19 forks source link

Data API should be stored object #28

Closed hoangnguyencong closed 8 years ago

hoangnguyencong commented 9 years ago

Code:

$('.myNode').data('myData', {myPro: 'my value'}); console.log($('.myNode').data());

output: DOMStringMap {myData: "[object Object]"}

expect: Object {myData: Object}

jgermade commented 8 years ago

Hi @hoangnguyencong , I've changed implementation to run as expected (like jquery does)

Also added $.fn.dataset to keep managing data-* (html5 handling) properties

Thanks for the feedback!

jgermade commented 8 years ago

Also, dataset works as fallback for data like jquery: https://api.jquery.com/data/#data-html5

hoangnguyencong commented 8 years ago

Hi @jgermade, thank you so much.