Marshal and unmarshal `EXT-X-MAP` and `EXT-X-BYTERANGE` tags

kim-company / kim_hls

M3U8 marshaler and unmarshaler. Playlist tracker

Apache License 2.0

4 stars 6 forks source link

Marshal and unmarshal `EXT-X-MAP` and `EXT-X-BYTERANGE` tags #14

Closed samrat closed 1 month ago

samrat commented 3 months ago

[x] Unmarshal EXT-X-MAP tags
[x] Marshal EXT-X-MAP tags. (I'll add this in a separate PR)

Fixes https://github.com/kim-company/kim_hls/issues/13

dmorn commented 2 months ago

Hi @samrat! Sorry for the very late feedback loop, I'll be faster now. Could you please provide some test cases for this feature? Seems a useful addition that fits well in the project's design so we're definitely interested in merging it.

samrat commented 2 months ago

👍 Will do!

samrat commented 2 months ago

I've pushed tests and changed the scope of this PR to only handle unmarshaling EXT-X-MAP tags.

When adding tests, I realized that streams using EXT-X-MAP tags are probably going to use EXT-X-BYTERANGE tags as well, so I've also added support for that in this PR.

philipgiuliani commented 1 month ago

@samrat Thanks very much for your contribution! We've implemented the marshaling and resolved the last TODOs.

samrat commented 1 month ago

👍 Thanks for pushing it over the finishing line, @philipgiuliani !