Closed samrat closed 1 month ago
Hi @samrat! Sorry for the very late feedback loop, I'll be faster now. Could you please provide some test cases for this feature? Seems a useful addition that fits well in the project's design so we're definitely interested in merging it.
👍 Will do!
I've pushed tests and changed the scope of this PR to only handle unmarshaling EXT-X-MAP tags.
When adding tests, I realized that streams using EXT-X-MAP tags are probably going to use EXT-X-BYTERANGE tags as well, so I've also added support for that in this PR.
@samrat Thanks very much for your contribution! We've implemented the marshaling and resolved the last TODOs.
👍 Thanks for pushing it over the finishing line, @philipgiuliani !
EXT-X-MAP
tagsEXT-X-MAP
tags. (I'll add this in a separate PR)Fixes https://github.com/kim-company/kim_hls/issues/13