search

kim-company / videojs-chromecast

Google Chromecast VideoJS Plugin
MIT License
84 stars 42 forks source link

Uncaught ReferenceError: settings is not defined #12

Closed steverandy closed 9 years ago

steverandy commented 9 years ago 
function ChromecastComponent(player, settings1) {
  this.settings = settings1;
  ChromecastComponent.__super__.constructor.call(this, player, settings);
  if (!player.controls()) {
    this.disable();
  }
  this.hide();
  this.initializeApi();
}

Shouldn't settings be this.settings?

philipgiuliani commented 9 years ago

This seems to be a bug of the new coffeescript compiler. Havent tested that before releasing the new version sorry. I will fix this today!

Steve Randy Tantra notifications@github.com schrieb am Mi., 15. Apr. 2015 04:28:

function ChromecastComponent(player, settings1) { this.settings = settings1; ChromecastComponent.super.constructor.call(this, player, settings); if (!player.controls()) { this.disable(); } this.hide(); this.initializeApi(); }

Shouldn't settings be this.settings?

— Reply to this email directly or view it on GitHub https://github.com/kim-company/videojs-chromecast/issues/12.

philipgiuliani commented 9 years ago

This one is fixed, i hope there is no other error. I currently have not time to test it. Before I release a new version, could you try it out?

I updated the files in the dist: https://github.com/kim-company/videojs-chromecast/tree/master/dist

steverandy commented 9 years ago

It's fixed. Thanks!

philipgiuliani commented 9 years ago

Thanks for reporting it! I should test the builds next time.. :)