VideoJS 5 Issue - Githubissues

DHoogland commented 8 years ago

Hey,

Could you/we maybe update this to VideoJS 5? It would be awesome!

philipgiuliani commented 8 years ago

Hi! Yes i definetly want to update it for VideoJS 5, but i think i will rewrite it in ES6. Currently i dont have enough time. But i will need it for my own project soon, than i update it! If somebody would like to help, would be great! I planned a rewrite to also address some older issues.

KaySackey commented 8 years ago

I'm curious. I'm just starting out using Video JS, so ofcourse I went with 5.0 but I've found that a lot of plugins are non compatible. Dev-to-dev, do you have any idea of what changed under the hood? Is this kind of something that'll need a full-rewrite of every plugin out there?

philipgiuliani commented 8 years ago

Hi @9cloud! Yes they have updated quite a lot... They rewrote VideoJS to the all new ES6 and are running babeljs.io as a transpiler to JS for current browsers.

Here you can see the changes. https://github.com/videojs/video.js/wiki/5.0-Change-Details

I can ensure that in the next month(s) i will update this here. I'll also rewrite it to ES6.

begriffs commented 8 years ago

+1 on video.js 5 support

joshmn commented 8 years ago

+1

razerrazer commented 8 years ago

+1

Jrubensson commented 8 years ago

+1

Bechrissed commented 8 years ago

+1

AvremelM commented 8 years ago

There's a fork of this that works on 5.0.

DHoogland commented 8 years ago

Thanks @HodofHod

Jrubensson commented 8 years ago

@HodofHod It doesn't work with desktop, or am I just doing something wrong?

razerrazer commented 8 years ago

How is it going with this?

ntamblyn commented 8 years ago

Any updates on this ?

onigetoc commented 8 years ago

+1

askaliuk commented 8 years ago

This fork works: https://github.com/PeterMHoward/videojs-chromecast

Tested on videojs 5.8.2

DHoogland commented 8 years ago

@askaliuk I can't seem to get the button to work/show up. The console is fine. Here a screenshot: http://i.imgur.com/7Gk3q6O.png

Using: "video.js": "^5.8.2", "videojs-chromecast": "PeterMHoward/videojs-chromecast#master"

askaliuk commented 8 years ago

@DHoogland I would recommend to debug it. The code is simple to understand. Make sure that Chromecast device in available from Chrome and works from YouTube.

You may even do it without repeating their build process. Just download and add main script to the page. Put some console.log in ChromecastComponent. In your case I would start with cast session initialization (ChromecastComponent.prototype.onSessionSuccess)

DHoogland commented 8 years ago

@askaliuk thanks for your reply. When I remove the appId it works. Any idea why?

The only thing i'm missing right now is Subtitles & closed captions in the cast plugin ^^ Maybe when I got some spare time!

ntamblyn commented 8 years ago

Have you registered your chromecast device within the google developer console?

Assuming you have set up a test receiver app.

If so i had this problem and by physicaly turning it off and on again it worked.

From: GreenBlueRup [notifications@github.com] Sent: 23 June 2016 18:19 To: kim-company/videojs-chromecast Cc: Nathan Tamblyn; Comment Subject: Re: [kim-company/videojs-chromecast] VideoJS 5 Issue (#17)

@askaliukhttps://github.com/askaliuk thanks for your reply. When I remove the appId it works. Any idea why?

� You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/kim-company/videojs-chromecast/issues/17#issuecomment-228119701, or mute the threadhttps://github.com/notifications/unsubscribe/AKVBFLn5EIIwrYgTHfCo9LkLtj-Np-X7ks5qOsARgaJpZM4G_GCe.

DHoogland commented 8 years ago

@ntamblyn I think I had to publish it first before I could try it. It seems to work now, awesome! thanks everyone for the time!

kim-company / videojs-chromecast

VideoJS 5 Issue #17