search

kim-company / videojs-chromecast

Google Chromecast VideoJS Plugin
MIT License
84 stars 42 forks source link

Session Management & text track support #19

Open ntamblyn opened 8 years ago

ntamblyn commented 8 years ago

Previously if you was to join a session you would only get a console log output of this. With the new changes you are able to actually join the session and control it.

Added text track support.

philipgiuliani commented 8 years ago

Hi! Thank you very much for your changes! I think you've understand something wrong in the project.

It is written in CoffeeScript, and will be translated to JavaScript when running grunt in the project folder. So the next time i'd run grunt all your changes are getting overridden. Thats also the reason why the js code looks so ugly ;) I only uploaded the JS code in the dist (distributed) folder so people dont have to build it themselves.

You think that you would be able to make the changes in the coffee files?

The commits of @PeterMHoward are ok!

In the Contribution section of the README you can find out how to get the setup done.

ntamblyn commented 8 years ago

Yes i can do this when i have some free time :) , obviously as you can tell i just changed the code in the dist folder .

philipgiuliani commented 8 years ago

I would help you out but its very hard to see the changes for me in the git diff because you reformatted the code ! :) Would be awesome. CoffeeScript is quite simple to learn. I'd love to migrate the project to es6, but i don't have time at the moment :(

ntamblyn commented 8 years ago

Yeah sorry for the reformat was the only way i could get my head around it for the session management comparing it to the google example. All this JS is new to me and i have a long way to go. So i am obviously making rookie mistakes :). I am just going through diffs and the coffee now to point out the changes i should make.