search

kim-marcel / basic_neural_network

A very basic Java Neural Network Library.
MIT License
39 stars 13 forks source link

Reading and Writing Networks #4

Open vishal-chandra opened 5 years ago

vishal-chandra commented 5 years ago

Hi! Great Library! I'm using it in this project and it's working great. However, the issue I'm having arises when saving a network. The file nn_data.json is being written to my root directory instead of the project folder. Support for custom file names would also be nice. Thanks.

kim-marcel commented 5 years ago

Hi, I'm very happy that you like this library and use it in your project! If you want you can add it as an example-project in the README. Just send me a pull request.

What do you mean with root directory? If it's being saved to the root of your project this is actually intended behavior.

I just added support for custom file names with v0.5. I hope you like it.

vishal-chandra commented 5 years ago

Thanks for the offer! I'll definitely link my project and send you a pull request soon.

By root directory I meant my user root directory rather than the project root. In my case (on Mac), it's being saved to /Users/vishalchandra. However, I've looked into the FileReaderAndWriter.writeToFile() method and haven't found anything that would lead to this behavior.

I'll try integrating v0.5 with my project and seeing if that fixes it. Thanks for your work on this!

kim-marcel commented 5 years ago

I just tried to recreate this issue and I get the same behavior.

However, this only seems to be a problem with Processing, a plain Java project works just fine.

I'll have a closer look soon.

vishal-chandra commented 5 years ago

Oh, that's interesting. Might be an issue with FileWriter itself and processing. I'll look into that as well.