Closed philderbeast closed 1 year ago
If we do this then we can get rid of two dependencies, flagged by -Wunused-packages
:
$ cabal build all --enable-tests --enable-benchmarks
Build profile: -w ghc-9.4.5 -O1
In order, the following will be built (use -v for more details):
- opentracing-0.2.2 (lib) (first run)
- opentracing-zipkin-common-0.2.2 (lib) (first run)
- opentracing-wai-0.2.2 (lib) (first run)
- opentracing-jaeger-0.2.2 (lib) (first run)
- opentracing-http-client-0.2.2 (lib) (first run)
- opentracing-zipkin-v2-0.2.2 (lib) (first run)
- opentracing-zipkin-v1-0.2.2 (lib) (first run)
- opentracing-examples-0.2.0 (lib) (first run)
- opentracing-examples-0.2.0 (exe:opentracing-example-simple) (first run)
- opentracing-examples-0.2.0 (exe:opentracing-example-rpc) (first run)
Configuring library for opentracing-0.2.2..
Preprocessing library for opentracing-0.2.2..
Building library for opentracing-0.2.2..
<no location info>: error: [-Wunused-packages, -Werror=unused-packages]
The following packages were specified via -package or -package-id flags,
but were not needed for compilation:
- semigroups-0.20 (exposed by flag -package-id
semigroups-0.20-4d7ca4412bb6d4e28787e3e5a5adfb2334f52bd1ca711fae9ce125ecd840f480)
- transformers-0.5.6.2 (exposed by flag -package-id transformers-0.5.6.2)
The ghc-8.6.1
build still works with those unused packages removed.
Fixed in #48
I tried 1e130d04efe49820a5658dae12c6f529f962f663 with low versions of GHC to find the minimum version I could compile with and that was
ghc-8.6.1
. I had this problem compiling withghc-8.4.4
:Should we bump the base minimum constraint like this?
Same story for 64fd0651c48844c8c40b790a6909c0ef4aea3382, the commit hash for the
0.2.2
tag.