search

kim42083 / webm

Automatically exported from code.google.com/p/webm
0 stars 0 forks source link

Add Preprocessor Definitions for x86_64 #370

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What is the expected behavior? What do you see instead?
Build libvpx for target=x86_64-win64-vs9. Open the solution in Visual Studio, 
and the Preprocessor Definitions of project property always have WIN32, but not 
any definition for x86_64. This causes error while building 
third_party/libyuv/source/scale.c, which has:
#if defined(WIN32)
...
#elif (defined(__x86_64__) || defined(__i386__))
...

What version are you using? On what operating system?
WebM Project VP8 Encoder v0.9.7-p1-107-gc4c3936. OS: Windows

Can you reproduce using the vpxdec or vpxenc tools? What command line are
you using?
Yes.

Please provide any additional information below.

Original issue reported on code.google.com by yunqingw...@google.com on 26 Oct 2011 at 8:31

GoogleCodeExporter commented 9 years ago

Original comment by yunqingw...@google.com on 26 Oct 2011 at 8:33

GoogleCodeExporter commented 9 years ago 
Could you look at it? Thanks.

Original comment by yunqingw...@google.com on 27 Oct 2011 at 12:04

GoogleCodeExporter commented 9 years ago 
The correct check is _WIN32, it's always defined by cl.exe.

Original comment by jz...@google.com on 1 Nov 2011 at 8:52

GoogleCodeExporter commented 9 years ago 
Hi James,

The definitions are used in scale.cc 
(http://code.google.com/p/libyuv/source/browse/trunk/source/scale.cc ; please 
see line 535, 620, 1475). What do you think we can do with that? Thanks.

Yunqing

Original comment by yunqingw...@google.com on 2 Nov 2011 at 7:07

GoogleCodeExporter commented 9 years ago 
If it's a mix of code then we should define it. I was just making a point that 
it would be simpler to just check for _WIN32. A change could be sent upstream 
for libyuv for this case.

Original comment by jz...@google.com on 2 Nov 2011 at 8:15

GoogleCodeExporter commented 9 years ago 
I looked at it again. Libyuv scale.c doesn't have code for WIN64 yet. Fritz 
also mentioned that there are problems while building libyuv on Windows, and 
we'd better use c version now. Therefore, there is nothing we need to change in 
libvpx now, and we can close this issue.

Original comment by yunqingw...@google.com on 4 Nov 2011 at 7:23

GoogleCodeExporter commented 9 years ago 
I'll change the Visual C 32 bit inline ifdefs to _M_IX86
Could you try a 64 bit ICL build?  Does __x86_64__ get defined?

Original comment by fbarch...@chromium.org on 17 Nov 2011 at 9:01