kimai / Paid-plugins

Support for paid Kimai plugins: Discussions and feature requests
https://www.kimai.org/store/
11 stars 1 forks source link

Expenses invoice/receipt - upload files #26

Open amanzone opened 4 years ago

amanzone commented 4 years ago

Hi @kevinpapst ,

in our case for some customers we need to attach invoices for the expenses. Of course I'm not suggesting to attach any file, but I think it would be very nice if there was a field where to save an url/path to the folder and filename where the invoice pdf scan in actually stored.

Do you think that would be feasible?

Ciao, A.

kevinpapst commented 4 years ago

Actually my plan was to add a file upload in the (near) future.

amanzone commented 4 years ago

Wow, that's actually more than I would have hoped for ;-)

For the sake of curiosity: I assume you don't actually want to store the uploaded files themselves in the db. As far as I can remember that's not really recommended, even if you use blob datatype, right?

You would maybe save the link to the file in the DB and then each separate file would be uploaded to a filesystem. Is this the case?

I'm asking because, aside from my curiosity, I would like to know in this case where the actual attached files would be stored, for backup porposes.

Thanks again!

Ciao, A.

kevinpapst commented 4 years ago

You are right: not in the database. My plans are right now to add a new var/uploads/ directory. But that will be announced together with the function.

amanzone commented 4 years ago

Do you think it would be possible to potentially let it be configurable... maybe to link it to a network folder?

HeinzWuert commented 4 years ago

This would be a great feature, also interesting for us!

fifty1-linh commented 4 years ago

+1 for this feature :-)

In addition to uploading the files, an export would also be necessary. Ideally also as a batch of a project/timesheet etc as a zip file.

labor4 commented 4 years ago

I was wondering time an again about uploads. I was never sure if it fits the export scheme. But I'm glad YOU've got a plan! ;-)

amanzone commented 4 years ago

@kevinpapst , while you're looking into this feature, I thought about a potential sub-case.

In our experience it happens sometimes that the receipt/invoice for an expense is actually "cumulative" in the sense that, for instance, you have a monthly invoice from a parking company, where you have parked your car in many days during the month. Usually in this case we have multiple entries in the expenses plugin, one per parking session, but one single invoice per month: in this case the multiple entries in kimai would point to the same receipt pdf file.

Just wanted to mention this in case it helps during your development.

Looking forward to testing the new feature!

amanzone commented 4 years ago

@kevinpapst , sorry to bother you again. Do you have any update on this topic?

Thanks for your support!

kevinpapst commented 4 years ago

I am sorry that my own timeline ("near future") didn't match the reality. Yes, I still want to work on it ... and I will give you an update here as soon as you can see / test it.

amanzone commented 3 years ago

Hi @kevinpapst , just bumping this request in case you have forgotten :-)

kevinpapst commented 3 years ago

I haven't forgotten. I tried once, failed and moved on with other features. There is no real concept for storing the documents.