When logging out and in again, the current filter for the timesheet should not get lost

[simonschaufi]

Describe the issue

I have set a filter (current week) in my timesheet view. When I create an invoice, I need to filter the last month which overwrites my timesheet filter but they should be independent of each other.

I already tried

• [X] I've read and searched the documentation.
• [X] I've searched for similar issues in this repository.
• [X] I've searched for similar issues in the discussions.

Kimai version

2.4.0

How do you run Kimai?

Virtual Server or alike

Which PHP version are you using?

8.1

Logfile

No response

Screenshots

No response

[kevinpapst]

They are independent. See kimai2_bookmarks table. The name is the query name. One time InvoiceQuery and one time MyTimesListing. I do not see how they could influence each other. Can you give me a click order to reproduce?

[simonschaufi]

Now that I tried to reproduce it, it works but since I always have a filter active and just created an invoice, I wonder what reset my filter than. Before creating an invoice, I also had to login. Maybe that was the cause? Maybe the filter also depend on a session?

Yes, when I logout and login again, the timesheet filter is reset. That is the issue!

[kevinpapst]

You had to re-authenticate, becuase you are accessing a sensitive area. The remember-me token is not sufficient to access invoicing or some parts of the administration.

There is a search filter that is persisted to DB and one in the session. Maybe that is related. You can simulate that by deleting your PHPSESSION cookie. I recommend to increased session lifetime to a high value (like a week) if this is your own server.

[simonschaufi]

I'm using a shared webhosting and can't adjust the session lifetime.

There is a search filter that is persisted to DB and one in the session. Maybe that is related.

I'm sure this is the case here.

[kevinpapst]

Usually you can add a php.ini in your own home directory. Anyway, I guess this is more of a confusing behavior than a bug?!?

If you can come up with a improved workflow of storing/handling these "search filter bookmarks" I am happy to talk about it.

[simonschaufi]

I would store them in a field in the users table merged all together (serialized or so)

[kevinpapst]

The new tit'e suggests that the filter is deleted upon logout, which is not the case.

If you use the search, the data will be temporarily persisted in the session, thus being cleared when changing the session.

But if you click the star icon in the search field, the filter will be persisted and applied in the new session as well.

[simonschaufi]

You are absolutely right but the thing is that I usually don't save my search because I forget it because I need to do that for every week again. It would be awesome if "current week" would always be selected from the current day.

The problem came up because Kimai forced me to login again which then cleared my search. That is then not a bug but simply a wrong behavior of the user and not the software. I'll close the issue for now but maybe you have a great idea how this can be achieved.

[kevinpapst]

A long outstanding issue is that the search can store filter names instead of absolute ranges for the date. So it show store and translate automatically "last_week" instead of "01.01.2024 - 07.01.2024".

[github-actions[bot]]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.