Closed lnNgyn1 closed 6 months ago
Congratulations on your first PR 👍 So cool, thank you very much!
Unfortunately I have to ask you to redo the change, becuase all these changed files should not be in there.
Are you experienced enough with GIT to revert all changes that are not related to your plugin? I just pushed a change in the translate-pages.php
script to main, to prevent overwriting existing files. Please apply this tiny change before running the command again.
Okay, I've reverted the changes and applied the small change you requested.
I think we need another elsif for gitlab at https://github.com/kimai/www.kimai.org/blob/main/_layouts/store-item.html#L55
And then you have to add your gitlab release page to the store data file, so people can actually get the plugin 😁
Edit: or you try the download option, if you don't want a specific gitlab button text and icon.
Oh, I have the bundle on GitHub now. I have it at this link, so that would avoid needing to add GitLab altogether, correct?
Makes it definitely easier, thanks 👍
Then we need only one extra line like this: https://github.com/kimai/www.kimai.org/blob/main/_data/store/vettersolutions-shared-project-timesheets-bundle.yml#L4
github: https://github.com/lnNgyn1/PeriodInsertBundle
Okay, I added the extra line and another one for cloning the repository under the bundle tag.
clone: "https://github.com/lnNgyn1/PeriodInsertBundle.git"
Looks good, thank you for keeping the bundle alive!
Changes
I ran
php translate-pages.php
but it seems like it modified files it should not have. Maybe there's an error in the files I added?PS: My first open-source contribution, woo!