search

kimchi-project / ginger

WoK plugin for host management
Other
66 stars 41 forks source link

Interface activate/deactivate method is doing unconfiguring ip addres instead of bringing up/down the link #82

Open jay-katta opened 8 years ago

jay-katta commented 8 years ago

Current implementation for activate/deactivate an interface - /plugins/ginger/network/interfaces/:interfacename/activate /plugins/ginger/network/interfaces/:interfacename/deactivate

Is executing ifup and ifdown on ifcfg file. Which is actually doing unconfiguring the IP address instead of bringing up/down the link. Due to that reason, I still see the operstate/carrier values are intact.

Instead ifup/ifdown if I use "ip link set enp0s25 up" or "ip link set enp0s25 down", actual status of link is going UP/DOWN.

Would like to provide this fix.

danielhb commented 8 years ago

I think that the original design of this feature (I wasn't around when it first got implemented) was that using ifup down/up would execute the startup/shutdown scripts of the interface as well. For example if you bring down an interface while freeing the IP address you can use that IP for another interface. When you bring it up again the script will run dhclient and reconfigure it.

Note that this design was also taking into account libvirt facilities to set the IP address and so on. So it is kind of deprecated and we'll end up reviewing it anyway.

IMO this is a discussion that needs to go to the ML because it will impact how Ginger works today. We can also discuss how to implement the network backend without libvirt (issue #45 ).

jay-katta commented 8 years ago

Please assign this issue to me