search

kimchi-project / gingers390x

Wok plug-in focused in s390x management
Other
6 stars 8 forks source link

Code fixes in initial s390x #2

Closed danielhb closed 8 years ago

danielhb commented 9 years ago

There were some code fixes/reviews that were made in Ginger ML over @archu-s patches and now must be applied to s390x:

  • def test_installed_paths(self): +(...)
  • def test_uninstalled_paths(self):

"The 2 tests above are related to Wok. So we don't need to duplicate it in the plugin. It is safe to remove them. "

  • def test_installed_plugin_paths(self):
  • GingerS390xPaths.get_prefix = lambda self: '@datadir@/wok'
  • paths = GingerS390xPaths()
  • self.assertInstalledPath(paths.conf_dir, '/etc/wok/plugins.d')
  • self.assertInstalledPath(paths.conf_file,
  • '/etc/wok/plugins.d/gingers390x.conf')
  • self.assertInstalledPath(paths.src_dir, '@wokdir@/plugins/gingers390x')
  • self.assertInstalledPath(paths.ui_dir,
  • '@datadir@/wok/plugins/gingers390x/ui')
  • self.assertInstalledPath(paths.mo_dir, '@prefix@/share/locale')

"Please, also add a test to cover the uninstalled plugin paths."

danielhb commented 8 years ago

Fixed upstream