windows is not identified as modern in osinfo.py

[JMiller7]

there is currently no entry for windows in modern_version_bases in osinfo.py

suggest:

modern_version_bases = {'x86': {'debian': '6.0', 'ubuntu': '7.10', 'opensuse': '10.3', 'centos': '5.3', 'rhel': '6.0', 'fedora': '16', 'gentoo': '0', 'sles': '11', 'arch': '0', 'windows': '0'},

[alinefm]

Hi @JMiller7

Which Windows version should be considered as modern? All them?

[crosscutrat]

I'm working with @JMiller7 on the same project and I'm pretty sure anything that is currently supported by Microsoft would be considered modern at least in context to osinfo.py. I would think anyone trying to virtualize an older version of Windows would need to make tweaks versus the assumption that the majority of people using Kimchi are working with supported versions.

[JMiller7]

I can't confirm, but I would guess any version Win9x forward would benefit from the settings made for modern OS designation in osinfo.py

[JMiller7]

ie: 'modern': dict(disk_bus='virtio', nic_model='virtio', tablet_bus='usb')},

[alinefm]

Hi @JMiller7 @crosscutrat

Yeap! We can consider adding it so Kimchi but I don't have any Windows ISO to test. Could you provide me the output of isoinfo -d -i <ISO-path> for different versions of Windows ? The most important values are related to those version you would consider modern, ie, Win95, Win98, Win2000, Win ME, Win XP, Win Vista, Win 7, Win8, Win8.1, Win10