search

kimchi-project / kimchi

An HTML5 management interface for KVM guests
https://github.com/kimchi-project/kimchi/releases/latest
Other
3.11k stars 364 forks source link

Save Button not sending #1111

Closed fritz-net closed 7 years ago

fritz-net commented 7 years ago

I use the current git versions which I installed over existing packages. When I try to change bootorder the new order is displayed in the console log but when i press save nothing happens (in the network tab only notification is loaded nothing else).

Which data should i append to help solving the issue? or where should i look if i'd like to try solving it myself?

fritz-net commented 7 years ago

I tried do make my installation clean from git (has not worked out perfectly). However i fixed the problem for me in https://github.com/fritz-net/kimchi/commit/b431852a96cd466eb2a47c7033aed3e180998e5c (I don't know yet how to make a pull request) Also the things i changed were recently changed so I'm not sure if there was a mistake or there is some version mismatch.

image

alinefm commented 7 years ago

Hi @fritz-net

Thanks for reporting and providing a patch. I got your patch from https://github.com/fritz-net/kimchi/commit/b431852a96cd466eb2a47c7033aed3e180998e5c.patch and have already applied it upstream.

Commit 5c80d731eec41c65f6d241a7898c832f1629b263

Please, next time you can follow the instructions at https://github.com/kimchi-project/kimchi/wiki/How-to-Contribute to submit a patch for review e etc. Kimchi community does not work based on pull requests.