kimchi-project / kimchi

An HTML5 management interface for KVM guests
https://github.com/kimchi-project/kimchi/releases/latest
Other
3.09k stars 365 forks source link

LDAP Auth: Users not specified as Wok Admins cannot see any guests, regardless if configured in Guest Permissions. #1183

Open GalenOfTheShadows opened 6 years ago

GalenOfTheShadows commented 6 years ago

Wok: 2.5 Kimchi: 2.5 LDAP: 2.4.44 (Installed w/FreeIPA)

LDAP authentication works perfectly, users can log in. Users not marked specifically as Administrators in the Wok configuration are unable to see any guests, even if the guest contains the user in the Permissions list. I am unable to locate any documentation describing if I need to preface the username with something LDAP specific or not. The error I see in the Wok log is:

[13/Oct/2017:12:26:02] HTTP Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/cherrypy/_cprequest.py", line 656, in respond response.body = self.handler() File "/usr/lib/python2.7/site-packages/cherrypy/lib/encoding.py", line 188, in call self.body = self.oldhandler(*args, *kwargs) File "/usr/lib/python2.7/site-packages/cherrypy/_cpdispatch.py", line 34, in call return self.callable(self.args, **self.kwargs) File "/usr/lib/python2.7/site-packages/wok/control/base.py", line 447, in index return self.get(params) File "/usr/lib/python2.7/site-packages/wok/control/base.py", line 422, in get data = self.filter_data(resources, fields_filter) File "/usr/lib/python2.7/site-packages/wok/control/base.py", line 400, in filter_data if not res.is_authorized(): File "/usr/lib/python2.7/site-packages/wok/control/base.py", line 239, in is_authorized return user_name in users or len(set(user_groups) & set(groups)) > 0 TypeError: 'NoneType' object is not iterable

Based on the little bit of code I've looked over in base.py, this appears to be an issue with reading the valid users and groups who have been given permission to the VM inside Kimchi, perhaps not an issue with the LDAP authentication?